Skip to content

Commit

Permalink
Fix issue where Key_Shared consumers could get stuck (apache#10920)
Browse files Browse the repository at this point in the history
(cherry picked from commit 8065d6c)
(cherry picked from commit f66d03d)
  • Loading branch information
Masahiro Sakamoto authored and eolivelli committed Oct 7, 2021
1 parent a3f0ada commit 2b05b8e
Showing 1 changed file with 1 addition and 0 deletions.
Expand Up @@ -126,6 +126,7 @@ public synchronized void removeConsumer(Consumer consumer) throws BrokerServiceE
// The consumer must be removed from the selector before calling the superclass removeConsumer method.
// In the superclass removeConsumer method, the pending acks that the consumer has are added to
// redeliveryMessages. If the consumer has not been removed from the selector at this point,
// messagesToRedeliver. If the consumer has not been removed from the selector at this point,
// the broker will try to redeliver the messages to the consumer that has already been closed.
// As a result, the messages are not redelivered to any consumer, and the mark-delete position does not move,
// eventually causing all consumers to get stuck.
Expand Down

0 comments on commit 2b05b8e

Please sign in to comment.