DATALAD_TESTS_GITCONFIG env variable to provide custom settings for git during tests #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
added
semver-tests
github-actions
bot
removed
the
CHANGELOG-missing
|
I'm not sure if you're using git-annex test, but if you are, it also ignores global gitconfigs. I've added a --test-with-git-config option to it that you could use to run the git-annex test suite with a git config set. |
|
it will need to wait for #7057 to get merged to get a kosher travis run. @joeyh thanks for the note! we do not do |
…g tests Although could be just once in a lifetime bug, we just got into an odd issue with an unlocked file with content being marked as modified https://git-annex.branchable.com/bugs/reports_file___34__modified__34___whenever_it_is_not/#comment-4e61c4c0f493e98f9416e09de4cfb33f which seems to boil down to have a rarely used `annex.stalldetection` set. By adding one more env variable for TESTS we can now add such specific setting to be tested in the tests.
yarikoptic
force-pushed
the
enh-test-gitconfig
branch
from
5bd7d56
to
812dcd8
Compare
|
Travis is happy, so either this PR is not in effect or we just do not have a test which |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although could be just once in a lifetime bug, we just got into an odd issue with an unlocked file with content being marked as modified https://git-annex.branchable.com/bugs/reports_file___34__modified__34___whenever_it_is_not/#comment-4e61c4c0f493e98f9416e09de4cfb33f which seems to boil down to have a rarely used
annex.stalldetectionset.By adding one more env variable for TESTS we can now add such specific setting to be tested in the tests.
TODOs