Merge pull request #7057 from yarikoptic/rf-chardet

Revert "Remove chardet version upper limit" to bring back upper limit <= 5.0.0 on chardet
datalad · Sep 23, 2022 · cc8cfb7 · cc8cfb7
2 parents 2de6ee6 + 52ab90f
commit cc8cfb7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/pr-7057.md b/changelog.d/pr-7057.md
@@ -0,0 +1,3 @@
+### Internal
+
+- Revert "Remove chardet version upper limit" (introduced in 0.17.6~11^2) to bring back upper limit <= 5.0.0 on chardet. Otherwise we can get some deprecation warnings from requests [PR #7057](https://github.com/datalad/datalad/pull/7057) (by [@yarikoptic](https://github.com/yarikoptic))
diff --git a/setup.py b/setup.py
@@ -26,7 +26,7 @@
 requires = {
     'core': [
         'platformdirs',
-        'chardet>=3.0.4',      # rarely used but small/omnipresent
+        'chardet>=3.0.4, <5.0.0',      # rarely used but small/omnipresent
         'colorama; platform_system=="Windows"',
         'distro; python_version >= "3.8"',
         'importlib-metadata >=3.6; python_version < "3.10"',