Rewrite #1
Merged
Rewrite #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be needed for generating --help text.
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
===========================================
+ Coverage 31.84% 64.26% +32.42%
===========================================
Files 1 1
Lines 292 876 +584
Branches 47 167 +120
===========================================
+ Hits 93 563 +470
- Misses 181 258 +77
- Partials 18 55 +37
Continue to review full report at Codecov.
|
|
Note that the pypy3 failures are due to a problem with the setup-python action. |
|
FTR that issue was fixed in 2.2.1, I've restarted the jobs |
It already carries a shebang. Having it executable simplifies the usecase of having this repository cloned and just trying to use it. I am not sure if there are any side-effects for it being used as Python module
ENH: make datalad_installer.py script executable
|
It is so green and much more complete than before, so to facilitate testing let's proceed with testing it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes datalad/datalad#5240.