Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: routine maintenance #4064

Merged
merged 12 commits into from
Feb 8, 2022
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Feb 6, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Changelog

  • Build/Testing/CI
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #4062

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-doc-fix labels Feb 6, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/G7rgbD9nLb6Yyp2RsyABEQiaw546
✅ Preview: Canceled

[Deployment for 6136232 canceled]

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #4064 (6136232) into main (72cde46) will increase coverage by 0%.
The diff coverage is 66%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #4064    +/-   ##
======================================
  Coverage     57%     57%            
======================================
  Files        830     829     -1     
  Lines      44352   44231   -121     
======================================
+ Hits       25486   25533    +47     
+ Misses     18866   18698   -168     
Impacted Files Coverage Δ
common/datavalues/src/data_schema.rs 84% <ø> (ø)
common/datavalues2/src/data_schema.rs 0% <ø> (ø)
common/meta/grpc/src/grpc_client.rs 0% <ø> (ø)
common/meta/types/src/match_seq.rs 100% <ø> (ø)
common/meta/types/src/user_auth.rs 57% <ø> (ø)
common/metrics/src/recorder.rs 100% <ø> (ø)
query/src/sql/planner/expression_binder.rs 0% <0%> (ø)
query/src/storages/github/github_table.rs 8% <0%> (ø)
query/src/pipelines/new/processors/processor.rs 60% <50%> (ø)
common/functions/src/scalars/hashes/sha1hash.rs 100% <100%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cde46...6136232. Read the comment docs.

Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE PsiACE removed the pr-doc-fix label Feb 7, 2022
@PsiACE PsiACE marked this pull request as ready for review February 7, 2022 12:53
@PsiACE PsiACE requested a review from BohuTANG as a code owner February 7, 2022 12:53
@PsiACE
Copy link
Member Author

PsiACE commented Feb 7, 2022

todo:

I will be opening a new PR to handle it, probably to be finished tomorrow.

@ariesdevil
Copy link
Member

ariesdevil commented Feb 7, 2022

LGTM, nice and slick.
If we were a little bit nitpicky, we could provide a way to make lint to sort dependencies alphabetically.

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG
Copy link
Member

BohuTANG commented Feb 8, 2022

/lgtm

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @PsiACE

@databend-bot databend-bot merged commit 396fcae into datafuselabs:main Feb 8, 2022
@PsiACE PsiACE deleted the maintenance branch February 10, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade packed_simd to 3.6.7 for arrow2
5 participants