Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging error #86

Closed
wants to merge 2 commits into from
Closed

Fix logging error #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a12f1f2
log error before handling it
stmarkevich Jan 21, 2022
96f1150
update black to avoid error "undefined symbol: _PyUnicode_DecodeUnico…
stmarkevich Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion channels_graphql_ws/graphql_ws_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ async def _on_gql_connection_init(self, payload):
# Notify subclass a new client is connected.
await self.on_connect(payload)
except Exception as ex: # pylint: disable=broad-except
LOG.error(str(ex))
await self._send_gql_connection_error(ex)
# Close the connection.
# NOTE: We use the 4000 code because there are two reasons:
Expand All @@ -491,7 +492,6 @@ async def _on_gql_connection_init(self, payload):
# So mozilla offers us the following codes:
# 4000–4999 - Available for use by applications.
await self.close(code=4000)
LOG.error(str(ex))
else:
# Send CONNECTION_ACK message.
await self._send_gql_connection_ack()
Expand Down
136 changes: 59 additions & 77 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.