Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using undocumented -k syntaxes. #1682

Merged
merged 1 commit into from Jul 29, 2020
Merged

Avoid using undocumented -k syntaxes. #1682

merged 1 commit into from Jul 29, 2020

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jul 29, 2020

As pytest 6.0.0 which was released on Jul 28, 2020 dropped undocumented -k syntaxes (pytest-dev/pytest#7210, pytest-dev/pytest#7122), we should use a full sentence query for the parameter:

ERROR: Wrong expression passed to '-k': not melt -to_delta -read_delta -to_clipboard: at column 10: expected end of input; got identifier

@ueshin ueshin requested a review from HyukjinKwon July 29, 2020 16:34
@ueshin
Copy link
Collaborator Author

ueshin commented Jul 29, 2020

I'd merge this now. cc @HyukjinKwon

@ueshin ueshin merged commit a1579b4 into databricks:master Jul 29, 2020
@ueshin ueshin deleted the pytest branch July 29, 2020 17:09
@HyukjinKwon
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon Awaiting requested review from HyukjinKwon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ueshin @HyukjinKwon