CloudSQL MySQL Plugin e2e test cases #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudSqlMySql Test Scenarios
e2e CloudSqlMySql
rmstar
reviewed
Aug 1, 2022
| @@ -0,0 +1,123 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright © 2015-2019 Cask Data, Inc. | |||
|
|
||
| <groupId>io.cdap.plugin</groupId> | ||
| <artifactId>e2e-test</artifactId> | ||
| <version>2.9.0-SNAPSHOT</version> |
There was a problem hiding this comment.
should it 1.9.0-SNAPSHOT?
Line 23 in 543dee0
| @@ -0,0 +1,120 @@ | |||
| /* | |||
| * Copyright © 2021 Cask Data, Inc. | |||
| public class E2ETestUtils { | ||
| private static Properties pluginProperties = new Properties(); | ||
| private static Properties errorProperties = new Properties(); | ||
| private static final Logger logger = Logger.getLogger(E2ETestUtils.class); |
There was a problem hiding this comment.
use slf4j
private static final Logger LOG = LoggerFactory.getLogger(E2ETestUtils.class);
| Feature: CloudSQLMySQl Sink Design Time | ||
|
|
||
| @CLDMYSQL @TC-Mandatory-fields | ||
| Scenario Outline:Verify CloudSQLMYSQL Sink properties validation errors for mandatory fields |
There was a problem hiding this comment.
for clarify, can we add source and sink test features in separate directories?
| Then Post records count from CloudSQLMySQL table "clsTableNameBQCS" | ||
| Then Validate the output record count | ||
| Then Validate successMessage is displayed | ||
| Then Validate the count of records transferred from BigQuery "clsTableNameBQ" to CloudSqlMySql "clsTableNameBQCS" |
There was a problem hiding this comment.
In addition to checking the number of records transferred, also validate that the correct data is written to the sink in all the test cases
| clsProjectID=cdf-athena | ||
| clsTableNameBQ=tableabc | ||
| clsTableNameBQ1=tablecloud | ||
| clsBucket=gs://cdf-athena-test/TestingGCS.csv |
There was a problem hiding this comment.
load data from the repo instead of depending on data existing in a GCS bucket. For example, see google-cloud tests - https://github.com/data-integrations/google-cloud/tree/develop/src/e2e-test/resources/testdata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tivv @rmstar @itsankit-google Please review.