Drop support for Python 3.7 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
crusaderky
commented
Mar 9, 2023
•
crusaderky
commented
- Drop support for Python 3.7
- Automatically call close() on dereferencing
- Add unit tests for update() and close()
crusaderky
force-pushed
the
py37
branch
5 times, most recently
from
ffa6a81
to
8343c2b
Compare
jrbourbeau
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thanks @crusaderky!
I pushed a small commit to bump python_requires in setup.cfg, hope you don't mind
|
Thank you both! 🙏 |
|
No problem! Sorry for the lack of response over in #72 -- that had completely dropped off my radar |
|
All good. Just happy to make the move generally. Support for more interesting things (like pickle protocol 5, shared memory, etc.) get easier with Python 3.8+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.