Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding_suspicious_worker #8647

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alex-rakowski
Copy link

@alex-rakowski alex-rakowski commented May 9, 2024

Adds suspicious workers msg

  • Tests added / passed
  • Passes pre-commit run --all-files

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Copy link
Contributor

github-actions bot commented May 9, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±    0      29 suites  ±0   10h 58m 44s ⏱️ + 1h 11m 55s
 4 051 tests  -     5   3 945 ✅ +    5     97 💤  -   9   9 ❌ + 3 
55 799 runs  +7 577  53 591 ✅ +7 306  2 159 💤 +246  49 ❌ +42 

For more details on these failures, see this check.

Results for commit 197284a. ± Comparison against base commit e4a0545.

This pull request removes 13 and adds 8 tests. Note that renamed tests count towards both.
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_collection
distributed.protocol.tests.test_highlevelgraph
distributed.protocol.tests.test_numpy
distributed.protocol.tests.test_pandas
distributed.shuffle.tests.test_graph
distributed.shuffle.tests.test_merge
distributed.shuffle.tests.test_merge_column_and_index
distributed.shuffle.tests.test_metrics
distributed.shuffle.tests.test_rechunk
…
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0]

♻️ This comment has been updated with latest results.

@fjetter
Copy link
Member

fjetter commented May 9, 2024

add to allowlist

distributed/tests/test_client.py Outdated Show resolved Hide resolved
distributed/tests/test_client.py Outdated Show resolved Hide resolved
distributed/tests/test_client.py Outdated Show resolved Hide resolved
@alex-rakowski alex-rakowski marked this pull request as ready for review May 10, 2024 09:56
@hendrikmakait hendrikmakait self-requested a review May 10, 2024 10:02
if ts.suspicious > self.allowed_failures:
log_msg["event"] = "killed-worker"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change event to action, maybe flag as an issue to enforce it/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants