Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Print host info" CI step on Mac OS (arm64) #8638

Merged
merged 3 commits into from May 7, 2024

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented May 6, 2024

Closes #8636

Print CPU freqs only when available

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait
Copy link
Member Author

Using an older version of psutil just changes the problem:

Traceback (most recent call last):
Number of CPUs: 3
  File "/Users/runner/work/distributed/distributed/continuous_integration/scripts/host_info.py", line 53, in <module>
Crude CPU benchmark (higher is better): 60.9
    main()
  File "/Users/runner/work/distributed/distributed/continuous_integration/scripts/host_info.py", line 33, in main
    freqs = psutil.cpu_freq(percpu=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/miniconda3/envs/dask-distributed/lib/python3.[12](https://github.com/dask/distributed/actions/runs/8972381061/job/24640250034?pr=8638#step:19:13)/site-packages/psutil/__init__.py", line 1876, in cpu_freq
    ret = _psplatform.cpu_freq()
          ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/miniconda3/envs/dask-distributed/lib/python3.12/site-packages/psutil/_psosx.py", line 179, in cpu_freq
    curr, min_, max_ = cext.cpu_freq()
                       ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory (originated from sysctl(HW_CPU_FREQ))

@hendrikmakait hendrikmakait changed the title Restrict psutil to fix CI Fix "Print host info" CI step on Mac OS (ARM64) May 6, 2024
@hendrikmakait hendrikmakait changed the title Fix "Print host info" CI step on Mac OS (ARM64) Fix "Print host info" CI step on Mac OS (arm64) May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  +     2      29 suites  +2   11h 3m 38s ⏱️ + 2h 9m 20s
 4 051 tests  -      5   3 948 ✅ +     4     97 💤  -   9  6 ❌ +4 
55 799 runs  +11 589  53 632 ✅ +11 210  2 160 💤 +391  7 ❌ +5 

For more details on these failures, see this check.

Results for commit 198ab8d. ± Comparison against base commit 1ec61a1.

This pull request removes 13 and adds 8 tests. Note that renamed tests count towards both.
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_collection
distributed.protocol.tests.test_highlevelgraph
distributed.protocol.tests.test_numpy
distributed.protocol.tests.test_pandas
distributed.shuffle.tests.test_graph
distributed.shuffle.tests.test_merge
distributed.shuffle.tests.test_merge_column_and_index
distributed.shuffle.tests.test_metrics
distributed.shuffle.tests.test_rechunk
…
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0]

@hendrikmakait hendrikmakait marked this pull request as ready for review May 6, 2024 17:46
@hendrikmakait hendrikmakait merged commit d5edb4e into dask:main May 7, 2024
28 of 36 checks passed
@hendrikmakait hendrikmakait deleted the fix-psutil-arm64 branch May 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print host info CI step raises RuntimeError: 'pmgr' entry was not found in AppleARMIODevice service for Mac OS
2 participants