Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move P2P's split_by_* tests #8631

Merged
merged 1 commit into from Apr 30, 2024

Conversation

hendrikmakait
Copy link
Member

Minor refactoring.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±    0      27 suites  ±0   10h 8m 12s ⏱️ + 1h 18m 10s
 4 051 tests  -     6   3 953 ✅ +   10     97 💤  -   9  1 ❌  - 3 
51 787 runs  +7 566  49 771 ✅ +7 340  2 015 💤 +246  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit c763a21. ± Comparison against base commit 5a588ae.

This pull request removes 18 and adds 12 tests. Note that renamed tests count towards both.
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_collection
distributed.protocol.tests.test_highlevelgraph
distributed.protocol.tests.test_numpy
distributed.protocol.tests.test_pandas
distributed.shuffle.tests.test_graph
distributed.shuffle.tests.test_merge
distributed.shuffle.tests.test_merge_column_and_index
distributed.shuffle.tests.test_metrics
distributed.shuffle.tests.test_rechunk
…
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0]
distributed.shuffle.tests.test_shuffle ‑ test_split_by_partition[False]
distributed.shuffle.tests.test_shuffle ‑ test_split_by_partition[True]
…

@hendrikmakait hendrikmakait merged commit 4986fa4 into dask:main Apr 30, 2024
30 of 35 checks passed
@hendrikmakait hendrikmakait deleted the move-split-by-worker-tests branch April 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants