Ensure inproc properly emulates serialization protocol #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Apr 17, 2024
| @@ -4676,9 +4676,6 @@ async def update_graph( | |||
| annotations: dict | None = None, | |||
| stimulus_id: str | None = None, | |||
| ) -> None: | |||
| # FIXME: Apparently empty dicts arrive as a ToPickle object | |||
There was a problem hiding this comment.
My initial diagnose was wrong. This has nothing to do with empty dicts
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ±0 29 suites ±0 11h 11m 46s ⏱️ + 4m 47s For more details on these failures, see this check. Results for commit b1d7d43. ± Comparison against base commit 3f13a2d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this again in #8612. Quite annoyingly, the InProc comm is not actually serializing stuff but is just emulating the behavior of the serialization protocol. This is nice because it should make our tests faster but it doesn't reflect reality since the ToPickle functionality is actually implemented on the serialization side, i.e. if we never serialize, the object stays untouched.
I could see how this fix also slows down the testsuite but I don't think we should just ignore this.