refactor(adaptive-core): improved readability recommendations #8431
Conversation
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 1h 4m 3s ⏱️ + 3m 2s For more details on these failures and errors, see this check. Results for commit c3958d9. ± Comparison against base commit c98cd09. ♻️ This comment has been updated with latest results. |
Vesyrak
force-pushed
the
refactor/recommendations
branch
from
4a56f58
to
6ca6212
Compare
| raise NotImplementedError() | ||
|
|
||
| async def recommendations(self, target: int) -> dict: | ||
| async def recommendations(self, target: int) -> Recommendation: |
There was a problem hiding this comment.
This is actually a breaking change since it is possible to subclass Adaptive and all consumers of recommendations would break.
There was a problem hiding this comment.
That's a very good point. I rewrote it into a TypedDict, so that it should remain backwards compatible while still improving readability.
Vesyrak
force-pushed
the
refactor/recommendations
branch
4 times, most recently
from
278cbac
to
4c1bfea
Compare
Vesyrak
force-pushed
the
refactor/recommendations
branch
from
4c1bfea
to
c3958d9
Compare
This improves the readability and fixes a long-standing API issue in the
adaptive_core