Ensure client key cancellation uses ordered messages #7583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another breakout from #7564
I can't specifically recall where I ran into this but while working on the refactor I somehow ran into race conditions around cancellation that prompted me to rewrite this section.
All administrative message, e.g. compute, release, cancel are sensitive to ordering. The current cancellation mechanism works around this by "waiting" for a task to show up because the current cancel was using an unordered RPC call (see also #7480)
The only other reason why one would want to poll at this point is if another client could cancel a given key. There is no API for this. User exposed APIs require the existence of a future object which, given message ordering, ensure that the task exists on the scheduler.