Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Click 7.0+ #7226

Merged
merged 1 commit into from Nov 8, 2022
Merged

Require Click 7.0+ #7226

merged 1 commit into from Nov 8, 2022

Conversation

jakirkham
Copy link
Member

As Dask now includes this requirement and has a minimum of Click 7.0, go ahead and align on that version in Distributed.

xref: dask/dask#9595

  • Tests added / passed
  • Passes pre-commit run --all-files

As Dask now includes this requirement and has a minimum of Click 7.0, go
ahead and align on that version in Distributed.
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 29m 9s ⏱️ - 4m 17s
  3 165 tests ±0    3 079 ✔️  - 1    84 💤 ±0  2 +1 
23 416 runs  ±0  22 511 ✔️  - 1  901 💤 ±0  4 +1 

For more details on these failures, see this check.

Results for commit 33b64d9. ± Comparison against base commit 1db2595.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham. Over in #4794 I also saw that we needed to bump our minimum version of click in order to get conda solve to work (similar to what we saw over in dask/dask). Bumping to 7.0 and matching dask/dask seems reasonable to me.

@jakirkham
Copy link
Member Author

Interesting that's a little surprising. In any event, if this helps, great!

@jakirkham jakirkham deleted the use_click_7 branch November 11, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants