Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bokeh=3 #5648

Merged
merged 20 commits into from
Nov 15, 2022
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ jobs:
run: mamba env update -n dask-distributed -f ${{ env.CONDA_FILE }}
if: steps.skip-caching.outputs.trigger-found == 'true' || steps.cache.outputs.cache-hit != 'true'

- name: Install old bokeh
if: matrix.python-version == '3.9'
shell: bash -l {0}
run: |
conda uninstall --force bokeh
mamba install -c conda-forge bokeh<3

- name: Install
shell: bash -l {0}
run: |
Expand Down
3 changes: 1 addition & 2 deletions continuous_integration/environment-3.10.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ dependencies:
- packaging
- pip
- asyncssh
# Temporary restriction until https://github.com/dask/distributed/issues/7173 is resolved
- bokeh<3
- bokeh
- click
- cloudpickle
- coverage
Expand Down
3 changes: 1 addition & 2 deletions continuous_integration/environment-3.8.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ dependencies:
- packaging
- pip
- asyncssh
# Temporary restriction until https://github.com/dask/distributed/issues/7173 is resolved
- bokeh<3
- bokeh
- click
- cloudpickle
- coverage
Expand Down
3 changes: 1 addition & 2 deletions continuous_integration/environment-3.9.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ dependencies:
- packaging
- pip
- asyncssh
# Temporary restriction until https://github.com/dask/distributed/issues/7173 is resolved
- bokeh<3
- bokeh
- click
- cloudpickle
- coverage
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/recipes/dask/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ requirements:
- lz4
- numpy >=1.18
- pandas >=1.0
- bokeh >=2.4.2,<3
- bokeh >=2.4.2
- jinja2

run_constrained:
Expand Down
2 changes: 0 additions & 2 deletions distributed/dashboard/components/nvml.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ def __init__(self, scheduler, width=600, **kwargs):
memory = figure(
title="GPU Memory",
tools="",
id="bk-gpu-memory-worker-plot",
width=int(width / 2),
name="gpu_memory_histogram",
**kwargs,
Expand All @@ -64,7 +63,6 @@ def __init__(self, scheduler, width=600, **kwargs):
utilization = figure(
title="GPU Utilization",
tools="",
id="bk-gpu-utilization-worker-plot",
width=int(width / 2),
name="gpu_utilization_histogram",
**kwargs,
Expand Down