-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Bokeh 3.0 CDSView change #5643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bryevdv -- just as a heads up there are a few known flaky tests, so if you see seemingly unrelated test failures in CI, that is most likely the cause
81c705f
to
37abc41
Compare
37abc41
to
748aee3
Compare
@jrbourbeau AFAICT everything is working fine with both 2.4.2 and 3.0.0dev I am seeing an error message on exit with 3.0dev
But that seems like something to handle in a separate issue |
@jrbourbeau I did dig into the three failed tests, all "macos, not ci1" tests and all with a few failures related to reconnection and/or timeouts. I don't think they pertain to anything Bokeh-related but any guidance is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bryevdv, those tests are definitely unrelated to the changes here
FWIW I'm running the full CI suite against the development version of |
Thanks @jrbourbeau ! |
Starting with Bokeh 3.0,
CDSView
will automatically infer the correctColumnDatSource
to apply to, and therefore no longer has asource
property. SeeCDSView.source
and infer the source fromCDSView
's parent bokeh/bokeh#11773This PR adds an version check to explicitly switch appropriate behavior.
pre-commit run --all-files
NOTE: just checking CI at this point, I still need to actually manually test with
3.0.0dev