New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMM: cosmetic tweaks #5584
AMM: cosmetic tweaks #5584
Conversation
@@ -1900,9 +1899,6 @@ def handle_acquire_replicas( | |||
recommendations[ts] = "fetch" | |||
|
|||
self.update_who_has(who_has, stimulus_id=stimulus_id) | |||
|
|||
for msg in scheduler_msgs: | |||
self.batched_stream.send(msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing fills this list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crusaderky
@@ -580,7 +584,7 @@ async def _tensordot_stress(c): | |||
|
|||
|
|||
@pytest.mark.slow | |||
@pytest.mark.xfail(reason="https://github.com/dask/distributed/issues/5371") | |||
@pytest.mark.avoid_ci(reason="distributed#5371") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a subjective comment, but I find using the full hyperlink in these situations nicer because I can quickly copy and paste the link into a browser and go right to the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, nice usage of avoid_ci
👍
Assorted uncontroversial cosmetic tweaks backported from #5381