Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMM: cosmetic tweaks #5584

Merged
merged 2 commits into from Dec 10, 2021
Merged

AMM: cosmetic tweaks #5584

merged 2 commits into from Dec 10, 2021

Conversation

crusaderky
Copy link
Collaborator

Assorted uncontroversial cosmetic tweaks backported from #5381

@@ -1900,9 +1899,6 @@ def handle_acquire_replicas(
recommendations[ts] = "fetch"

self.update_who_has(who_has, stimulus_id=stimulus_id)

for msg in scheduler_msgs:
self.batched_stream.send(msg)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing fills this list

@crusaderky crusaderky self-assigned this Dec 10, 2021
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky

@@ -580,7 +584,7 @@ async def _tensordot_stress(c):


@pytest.mark.slow
@pytest.mark.xfail(reason="https://github.com/dask/distributed/issues/5371")
@pytest.mark.avoid_ci(reason="distributed#5371")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a subjective comment, but I find using the full hyperlink in these situations nicer because I can quickly copy and paste the link into a browser and go right to the issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, nice usage of avoid_ci 👍

@jrbourbeau jrbourbeau merged commit b9f0517 into dask:main Dec 10, 2021
@crusaderky crusaderky deleted the AMM/cosmetic branch December 13, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants