Improve pull request review experience by tagging them based on size and contents #5402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two workflows. The first one tags new pull requests based on their size and the files changed. This action attempts to programmatically segment new pull requests into several overlapping buckets:
You can see it in action here: https://github.com/orf/distributed/pull/7. As the pull request is updated the tags also are updated to reflect the contents.
Why? In any project like this reviewer time is limited. We can use the size of the pull request as a proxy for how long it will take to review - it's not perfect, but I think it's a good heuristic to use. In a similar vein, PRs that only impact tests and docs likely require less discussion or are possibly easier to review - a tiny PR that only touches tests is usually pretty simple to review and merge. With this people can now see at a glance which PRs they might be able to look at in a given time frame.
It's also fairly easy to add new tags based on the files changed, for example we could add
dashboard
,protocol
ordiagnostics
labels to indicate changes isolated to those modules.The second action closes stale pull requests. A large percentage of the open pull requests are over a year old, and it's probably a good thing to mark them as stale and close them.