Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark test_worker_reconnects_mid_compute* tests as flaky #5378

Merged
merged 3 commits into from Oct 5, 2021
Merged

Mark test_worker_reconnects_mid_compute* tests as flaky #5378

merged 3 commits into from Oct 5, 2021

Conversation

jrbourbeau
Copy link
Member

xref #5377

@jrbourbeau jrbourbeau mentioned this pull request Oct 1, 2021
Merged
jakirkham
jakirkham approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 😄

@jakirkham
Copy link
Member

jakirkham commented Oct 1, 2021 •
edited

Seeing test_stress_creation_and_deletion fail on CI here and here, which is already noted as a flaky test in issue ( #5172 ).

Also seeing test_client_timeout fail on CI here. Not seeing any open issues about it.

@jrbourbeau
Copy link
Member Author

xref #5393 for test_stress_creation_and_deletion

@crusaderky
Copy link
Collaborator

The same should also be applied to test_worker_reconnects_mid_compute

@crusaderky
Copy link
Collaborator

According to my latest stress test, test_client_timeout fails exclusively on MacOS.

@jrbourbeau jrbourbeau changed the title Mark test_worker_reconnects_mid_compute_multiple_states_on_scheduler as flaky Mark test_worker_reconnects_mid_compute* tests as flaky Oct 5, 2021
@jrbourbeau
Copy link
Member Author

Just pushed a commit to mark test_worker_reconnects_mid_compute as flaky too.

@jakirkham for reference, @crusaderky is running a bunch of stress tests on the distributed test suite to see what tests fail, how often, etc. Let's leave test_client_timeout for after we have the results of those stress tests. Right now I'm mostly concerned about test_worker_reconnects_mid_compute* and test_stress_creation_and_deletion as they are failing at a high rate.

@jakirkham
Copy link
Member

Sure am mostly just trying to get a sense of what flaky test failures we are dealing with since there appear to be several

@jrbourbeau jrbourbeau merged commit 07d8e4c into dask:main Oct 5, 2021
@jrbourbeau jrbourbeau deleted the flaky-test branch October 5, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@crusaderky crusaderky crusaderky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrbourbeau @jakirkham @crusaderky