Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pickle protocols 4 & 5 #5313

Merged
merged 1 commit into from Sep 11, 2021
Merged

Test pickle protocols 4 & 5 #5313

merged 1 commit into from Sep 11, 2021

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Sep 11, 2021

Covers testing of both pickle protocol 4 & 5 in the pickle serialization test suite. This should help catch assumptions predicated on protocol 5 being in use that are not always the case (as happened with the test failure in cloudpickle recently).

xref: #5303
xref: cloudpipe/cloudpickle#432

  • Closes #xxxx
  • Tests added / passed
  • Passes black distributed / flake8 distributed / isort distributed

Covers testing of both pickle protocol 4 & 5 in the pickle serialization
test suite. This should help catch assumptions predicated on protocol 5
being in use that are not always the case (as happened with the test
failure in cloudpickle recently).
@jakirkham jakirkham mentioned this pull request Sep 11, 2021
3 tasks
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham!

@jrbourbeau jrbourbeau merged commit 518024a into dask:main Sep 11, 2021
@jakirkham jakirkham deleted the tst_pickle_45 branch September 11, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants