Mark test_ucx_config_w_env_var flaky on UCX < 1.11 #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test has also been slightly cleaned up.
|
cc @fjetter for original report. |
|
Thanks @jakirkham for reviewing/merging this one too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #5229, the test is flaky. I believe this is an issue that sometimes happens with
client.runwhen UCX connections to the worker are closed. This has been significantly improved in UCX 1.11+, so the test is only marked flaky for older versions, and hopefully after the update to UCX 1.11 (probably happening within a month) the test will be stable again.Test has also been slightly cleaned up.