Fix flaky test_threaded.py::test_interrupt
#9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Jan 12, 2023
dask/tests/test_threaded.py
Outdated
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| import pytest | |||
|
|
|||
| from distributed.utils_test import cleanup # noqa: F401 | |||
There was a problem hiding this comment.
distributed is actually only an optional dependency of dask. This is why the mindeps build fails
There was a problem hiding this comment.
I think a separate PR that checks for leaked threads at the end of every test would be good here?
There was a problem hiding this comment.
Yeah, I think checking for leaks might generally be a good idea.
fjetter
reviewed
Jan 12, 2023
fjetter
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
test_threaded.py::test_interruptusing events instead of time-based actions to avoid flakiness on CI and speedup the test in general.pre-commit run --all-files