Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial functions in aggs may have arguments #9724

Merged
merged 8 commits into from
Dec 9, 2022
Merged

Partial functions in aggs may have arguments #9724

merged 8 commits into from
Dec 9, 2022

Commits on Dec 7, 2022

  1. Partial functions in aggs may have arguments.

    @j-bennet
    j-bennet committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5b340aa View commit details
    Browse the repository at this point in the history

  2. Test with multiple partitions. 

    Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
    @j-bennet @jrbourbeau
    j-bennet and jrbourbeau committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    08972d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Handle unexpected args in partials.

    @j-bennet
    j-bennet committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ac29a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Added positional args test case, updated kwargs case with review feed… 

    …back.
    @j-bennet
    j-bennet committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bb9f70b View commit details
    Browse the repository at this point in the history

  2. Compute calls are not necessary, exceptions happens without computing 

    Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
    @j-bennet @jrbourbeau
    j-bennet and jrbourbeau committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    dc2d707 View commit details
    Browse the repository at this point in the history

  3. Reword exceptons, and complain about all kwargs at the same time.

    @j-bennet
    j-bennet committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9eb52e7 View commit details
    Browse the repository at this point in the history

  4. Fix typo 

    Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
    @j-bennet @jrbourbeau
    j-bennet and jrbourbeau committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ae95ec3 View commit details
    Browse the repository at this point in the history

  5. No need for set 

    Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
    @j-bennet @jrbourbeau
    j-bennet and jrbourbeau committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    cd56f25 View commit details
    Browse the repository at this point in the history