[WIP] Support pandas mode.string_storage option in read_parquet
#9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Dec 2, 2022
There was a problem hiding this comment.
Okay, there are two related test failures in CI
dask/dataframe/io/tests/test_parquet.py::test_use_nullable_dtypes_with_types_mapperdask/dataframe/io/tests/test_parquet.py::test_use_nullable_dtypes
Interestingly I'm when I run those tests individually locally, they pass. But when I run the entire dask/dataframe/io/tests/test_parquet.py test module I can reproduce the failures. So seems like there is some sort of interference across tests. Will need to look into this more...
EDIT: nvm -- this was me being silly. Pushing a commit to use a context manager when setting string_storage in test_pandas_string_storage_option
github-actions
bot
added
the
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing up a quick diff to help aid the conversation happening here #9631 (comment). The
test_pandas_string_storage_optiontest added here demonstrates the behavior we ultimately want, but the actual changes toread_parquetare still preliminary (I suspect we'll need more changes).