New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize array checking and remove pd.Index
call in _get_partitions
#9634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @quasiben! Can we add a test for this?
pd.Index
call in _get_partitions
Thanks for the review @jrbourbeau -- added a test and found another spot where we needed another array-like call |
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
My guess is the gpuCI failures are unrelated (saw them here yesterday #9635 (review)), though it'd be great if you could confirm |
@jrbourbeau , yes, they are unrelated. I filed #9639 to track the failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @quasiben
This PR does two things:
pd.Index
call .This fixes an issue for dask-cudf where users want to index a Dask Dataframe with a cudf/cupy object:
The
pd.Index
call is quite old (#1913) and was originally written to handle indexing with lists. Locally I randask/dataframe/tests/test_indexing.py
and all tests still pass as well as verifying manually that lists are still supportedpre-commit run --all-files
cc @VibhuJawa @rjzamora