Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid
pandas
constructors indask.dataframe.core
#9570Avoid
pandas
constructors indask.dataframe.core
#9570Changes from all commits
a59af4a
5ec150d
91538c8
dfe1114
1ba0353
97ceffd
ee35931
8ad7e72
5c49d07
8b88469
4e8ed06
61ee8ab
a2613f5
ed3620f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
data
here? Can we get the DataFrame type from that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data
islist[dict[str, np/cupy.ndarray]]
here. Therfore, we would need to extendserial_frame_constructor
to handle array-like data if we want to avoid thelike_df
argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1ba0353 adds a
serial_constructor_from_array
dispatch (but doesn't actually use it yet) to illustrate what it would probably look like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not a blocking comment, just meant for other reviewers) Noting that this will fail for some inputs (e.g.
numpy.ndarray
s) that are supported bypandas.to_timedelta
. However, it looks like things already fail withdd.to_timedelta
for such inputs onmain
and we arguably get a better error message with the changes in this PR.On
main
:With this PR:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the backend PR goes in before this PR, could we just reuse
test_cov
with the backend engine parametrized?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps. We would need to change the
_compat
dataframe-creation machinery to use dispachable functions to do this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment here