Use entry_points utility in sizeof
#9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Aug 17, 2022
Comment on lines
+18
to
+24
| if _PY_VERSION >= parse_version("3.10"): | ||
| return importlib.metadata.entry_points(group=group) | ||
| else: | ||
| eps = importlib.metadata.entry_points() | ||
| if group: | ||
| return eps.get(group, []) | ||
| return eps | ||
| return eps |
There was a problem hiding this comment.
This is purely just moving code around to we can use _PY_VERSION instead of a try/except, not a functional change. IMO this makes it a bit easier to see when this can be removed as we'll grep for _PY_VERSION when adding/removing Python versions. Just personal preference -- happy to discard this change if others feel strongly
There was a problem hiding this comment.
this makes it a bit easier to see when this can be removed as we'll grep for _PY_VERSION when adding/removing Python versions
makes sense to me!
jacobtomlinson
approved these changes
Aug 17, 2022
|
Thanks for reviewing @douglasdavis @jacobtomlinson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #9388, I remembered that we're using entrypoints in
sizeof. This PR makes use of our new utility when handlingdask.sizeofentrypoints.cc @jacobtomlinson