Unpack namedtuple
#9361
Unpack namedtuple
#9361
Conversation
|
CI flake: #8795 |
There was a problem hiding this comment.
Thanks @hendrikmakait, I think this is a nice feature. Can we add similar functionality to dask.base.unpack_collections?
hendrikmakait
force-pushed
the
unpack-namedtuple
branch
from
942194e
to
46a6b57
Compare
|
@ian-r-rose, I adjusted |
|
|
||
| Note: This function checks for the existence of the methods and | ||
| attributes that make up the namedtuple API, so it will return True | ||
| IFF obj's type implements that API. |
There was a problem hiding this comment.
Nit: I don't think iff is accurate here, I could easily create an object that has these attributes and is not a namedtuple.
There was a problem hiding this comment.
This might be arguing over semantic details but in that case your object implements the namedtuple API. I actually tried to word this carefully to NOT say that the object is a namedtuple. LMK what you think :)
There was a problem hiding this comment.
Definitely semantic, I don't expect it to come up. But there's no guarantee that these attributes do the same thing as the namedtuple APIs.
This PR adds support for unpacking
namedtuples inunpack_collectionsandto_task_graph.pre-commit run --all-files