Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chest #8279

Merged
merged 1 commit into from Oct 21, 2021
Merged

Remove chest #8279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion continuous_integration/environment-3.7.yaml
View file
Open in desktop
Expand Up @@ -37,7 +37,6 @@ dependencies:
- aiohttp
- bokeh
- httpretty
- chest
- s3fs
- cloudpickle
- crick
Expand Down
1 change: 0 additions & 1 deletion continuous_integration/environment-3.8-dev.yaml
View file
Open in desktop
Expand Up @@ -38,7 +38,6 @@ dependencies:
- aiohttp
- bokeh
- httpretty
- chest
- cloudpickle
- crick
- cytoolz
Expand Down
1 change: 0 additions & 1 deletion continuous_integration/environment-3.8.yaml
View file
Open in desktop
Expand Up @@ -37,7 +37,6 @@ dependencies:
- bokeh
- httpretty
- aiohttp
- chest
- s3fs
- cloudpickle
- crick
Expand Down
1 change: 0 additions & 1 deletion continuous_integration/environment-3.9.yaml
View file
Open in desktop
Expand Up @@ -38,7 +38,6 @@ dependencies:
- bokeh
- httpretty
- aiohttp
- chest
- s3fs
- cloudpickle
- crick
Expand Down
5 changes: 0 additions & 5 deletions dask/dataframe/core.py
View file
Open in desktop
Expand Up @@ -18,11 +18,6 @@
from pandas.util import cache_readonly
from tlz import first, merge, partition_all, remove, unique

try:
from chest import Chest as Cache
except ImportError:
Cache = dict

Comment on lines -21 to -25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache isn't used anymore

from .. import array as da
from .. import core, threaded
from ..array.core import Array, normalize_arg
Expand Down
10 changes: 0 additions & 10 deletions dask/local.py
View file
Open in desktop
Expand Up @@ -134,9 +134,6 @@ def queue_get(q):
return q.get()


DEBUG = False


def start_state_from_dask(dsk, cache=None, sortkey=None):
"""Start state from a dask

Expand Down Expand Up @@ -274,13 +271,6 @@ def finish_task(
s = state["waiting_data"][dep]
s.remove(key)
if not s and dep not in results:
if DEBUG:
from chest.core import nbytes

print(
"Key: %s\tDep: %s\t NBytes: %.2f\t Release"
% (key, dep, sum(map(nbytes, state["cache"].values()) / 1e6))
)
Comment on lines -277 to -283
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this DEBUG flag being used anywhere else. It was probably useful at one point, but I'm fine removing this conditional print

release_data(dep, state, delete=delete)
elif delete and dep not in results:
release_data(dep, state, delete=delete)
Expand Down
6 changes: 1 addition & 5 deletions dask/tests/test_local.py
View file
Open in desktop
Expand Up @@ -97,11 +97,7 @@ def test_get_sync_num_workers(self):


def test_cache_options():
try:
from chest import Chest
except ImportError:
return
cache = Chest()
cache = {}

def inc2(x):
assert "y" in cache
Expand Down