Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale label github action #8244

Merged
merged 3 commits into from Oct 19, 2021
Merged

Stale label github action #8244

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa2442
Stale label github actions
GenevieveBuckley Oct 11, 2021
b51a101
Update stale-bot.yaml
GenevieveBuckley Oct 11, 2021
b2864d5
Update .github/workflows/stale-bot.yaml
GenevieveBuckley Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/stale-bot.yaml
View file
Open in desktop
@@ -0,0 +1,21 @@
name: 'Label stale issues and PRs'
on:
schedule:
- cron: '30 1 * * 1' # runs once a week
GenevieveBuckley marked this conversation as resolved.
Show resolved Hide resolved

jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v4
with:
stale-issue-message: '' # no comment left if string is empty
stale-pr-message: '' # no comment left if string is empty
days-before-stale: 30
days-before-close: -1
stale-issue-label: 'needs attention'
stale-pr-label: 'needs attention'
exempt-issue-labels: 'good intro to dask,good first issue,Good First Issue,good second issue,feature request'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of labels could be tidied up a bit.

  • Discussed previously, "good first issue" is going to get changed to "good intro to dask" but this hasn't happened just yet (I can't do it - to edit labels you need write permissions to a repository & I only have triage team permissions here)
  • The "good first issue" label in dask/dask is all lowercase, but over in distributed it's "Good First Issue" (title case). I figure people are reasonably likely to copy-paste yaml files to other repos, so it seems easier to just have extra redundancy here even if it could be more succinct.

exempt-pr-labels: 'awaiting-approval,work-in-progress'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually seem to use labels like these in either dask or dask/distributed. I could take them out, or like above I could leave them in just so it's clearer how to use the yaml file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take them out or comment them out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll comment it out then. That's a bit easier than making someone dig around in the documentation later on if they want to just change something quickly.

exempt-draft-pr: true
start-date: '2020-04-18T00:00:00Z' # ignore before this date, ISO 8601 or RFC 2822
GenevieveBuckley marked this conversation as resolved.
Show resolved Hide resolved