Temporarily pin sphinx version to 3.3.1 #7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravwojdyla
changed the title
jrbourbeau
reviewed
Dec 21, 2020
| @@ -1,5 +1,5 @@ | |||
| numpydoc | |||
| sphinx | |||
| sphinx==3.3.1 | |||
There was a problem hiding this comment.
Thanks for reporting and fixing this issue upstream @ravwojdyla! Could you please add a comment that informs others when we can remove this pinning. Something like:
Suggested change
| sphinx==3.3.1 | |
| # TODO: Remove sphinx pinning once sphinx==3.4.1 is released | |
| # See https://github.com/dask/dask/issues/7001 | |
| sphinx==3.3.1 |
There was a problem hiding this comment.
@jrbourbeau done.
ravwojdyla
force-pushed
the
rav/pin_sphinx
branch
from
77e85d0
to
0e5f786
Compare
ravwojdyla
added a commit
to ravwojdyla/dask
that referenced
this pull request
Dec 28, 2020
This reverts commit 4a7a243.
2 tasks
ravwojdyla
added a commit
to ravwojdyla/dask
that referenced
this pull request
Dec 28, 2020
This reverts commit 4a7a243.
jsignell
pushed a commit
that referenced
this pull request
Jan 7, 2021
abduhbm
pushed a commit
to abduhbm/dask
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related sphinx-doc/sphinx#8568 (#7001). When 3.4.1 is out, we can revert this commit.
black dask/flake8 dask