Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pytest error when skipping NumPy 2.0 tests #11110

Merged
merged 2 commits into from
May 8, 2024

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented May 8, 2024

This fixes errors like

ERROR dask/bytes/tests/test_s3.py::test_parquet[fastparquet-True] - pytest.PytestDeprecationWarning: 
Module 'fastparquet' was found, but when imported by pytest it raised:
    ImportError("numpy.core.multiarray failed to import (auto-generated because you didn't call 'numpy.import_array()' after cimporting numpy; use '<void>numpy._import_array' to disable if you are certain you don't need it).")
In pytest 9.1 this warning will become an error by default.
You can fix the underlying problem, or alternatively overwrite this behavior and silence this warning by passing exc_type=ImportError explicitly.
See https://docs.pytest.org/en/stable/deprecations.html#pytest-importorskip-default-behavior-regarding-importerror

in the upstream build

EDIT: Closes #10855

@jrbourbeau
Copy link
Member Author

Added that this issue closes #10855 as the upstream build is green now

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 25m 20s ⏱️ + 1m 41s
 13 121 tests ±0   12 190 ✅ ±0     931 💤 ±0  0 ❌ ±0 
162 468 runs  ±0  142 442 ✅ +3  20 026 💤  - 3  0 ❌ ±0 

Results for commit 0569152. ± Comparison against base commit aba2198.

@phofl phofl merged commit aabc53d into dask:main May 8, 2024
28 checks passed
@phofl
Copy link
Collaborator

phofl commented May 8, 2024

thx

@jrbourbeau jrbourbeau deleted the s3-test-numpy-2 branch May 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Upstream CI failed ⚠️
2 participants