Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nightly scikit-image in upstream CI build #11107

Merged
merged 2 commits into from
May 7, 2024

Conversation

jrbourbeau
Copy link
Member

This fixes the

ERROR dask/array/tests/test_image.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

errors we're currently seeing in the upstream build due to scikit-image / NumPy 2.0 compatibility

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jrbourbeau! LGTM assuming CI ends up being happy.

Copy link
Contributor

github-actions bot commented May 7, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  +     12       15 suites  +12   3h 21m 46s ⏱️ + 3h 15m 54s
 13 121 tests +  7 795   12 190 ✅ +  7 638     931 💤 +   157  0 ❌ ±0 
162 468 runs  +154 861  142 438 ✅ +136 044  20 030 💤 +18 817  0 ❌ ±0 

Results for commit 2eb8f57. ± Comparison against base commit c619f1d.

@phofl phofl merged commit 7ace31f into dask:main May 7, 2024
27 of 28 checks passed
@phofl
Copy link
Collaborator

phofl commented May 7, 2024

thx

@jrbourbeau jrbourbeau deleted the nightly-skimage branch May 7, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants