New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip fastparquet tests for numpy 2 #11103

Merged

jrbourbeau merged 2 commits into dask:main from phofl:fastparquet-skip

May 6, 2024

Collaborator

phofl commented May 6, 2024

Closes #xxxx
Tests added / passed
Passes pre-commit run --all-files

see dask/fastparquet#923


          Skip fastparquet tests for numpy 2

47442ab

jrbourbeau approved these changes

View reviewed changes

Member

jrbourbeau left a comment

Thanks @phofl -- LGTM if it improves CI

dask/bytes/tests/test_s3.py Outdated

Comment on lines 559 to 560

		if dd._dask_expr_enabled():
		pytest.skip("need convert string option")

Member

jrbourbeau May 6, 2024

I'm assuming we're removing this because this functionality exists now

Collaborator Author

phofl May 6, 2024

This wasn't fixed (different root cause), but have a PR up now that will fix it

dask/bytes/tests/test_s3.py Outdated

Comment on lines 466 to 467

		if NUMPY_GE_200 and engine == "fastparquet":
		pytest.skip("fastparquet doesn't work with Numpy 2")

Member

jrbourbeau May 6, 2024

Would you mind leaving a comment pointing to the upstream issue so we know when we can remove these skips?

Contributor

github-actions bot commented May 6, 2024 •

edited

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

15 files + 1 15 suites +1 3h 25m 30s ⏱️ + 18m 49s
13 121 tests ± 0 11 730 ✅ ± 0 931 💤 ± 0 460 ❌ ±0
162 468 runs +12 961 141 926 ✅ +11 792 20 082 💤 +1 169 460 ❌ ±0

For more details on these failures, see this check.

Results for commit b7401b0. ± Comparison against base commit e96ce52.

♻️ This comment has been updated with latest results.


          Fixup

b7401b0

jrbourbeau merged commit 7b2a47e into dask:main

26 of 27 checks passed

phofl deleted the fastparquet-skip branch

May 6, 2024 20:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment