Fix misspelling found by codespell #11097
Conversation
|
Can one of the admins verify this patch? Admins can comment |
DimitriPapadopoulos
force-pushed
the
codespell
branch
3 times, most recently
from
694c6f8
to
10779d3
Compare
| @@ -1673,8 +1673,8 @@ def block_index_shape_from_1d_bool_index(dim, loc0, loc1): | |||
| return np.sum(index[loc0:loc1]) | |||
|
|
|||
| @functools.lru_cache | |||
| def n_preceeding_from_1d_bool_index(dim, loc0): | |||
| """Number of True index elements preceeding position loc0. | |||
| def n_preceding_from_1d_bool_index(dim, loc0): | |||
There was a problem hiding this comment.
Is it OK to change the function name? It's not part of the API as far as I can see — setitem_array is missing from the documentation.
There was a problem hiding this comment.
I'd rather not change this, Dask and public API is a bit weird sometimes, even though I agree with you that nobody should be using it
There was a problem hiding this comment.
Perhaps duplicate the function (it's very short) and add a deprecation notice to the existing one?
There was a problem hiding this comment.
yep, you can just call the new function from the old one
There was a problem hiding this comment.
I call the old deprecated function from the new one - I suspect that's what you meant.
I have removed the cache associated to the old function, since it merely calls the new function which is cached.
DimitriPapadopoulos
force-pushed
the
codespell
branch
from
10779d3
to
38e9e8d
Compare
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 24m 4s ⏱️ -49s For more details on these failures, see this check. Results for commit 03456a2. ± Comparison against base commit 067c668. ♻️ This comment has been updated with latest results. |
|
thx |
pre-commit run --all-files