skip dataframe/product when in numpy 2 envs #11089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasiben
commented
May 2, 2024
| if redfunc in ("var", "std"): | ||
| # numpy has default ddof value 0 while | ||
| # dask and pandas have 1, so ddof should be passed | ||
| # explicitly when calling np.var(dask) | ||
| expect = np_redfunc(pdf, axis=axis, ddof=1) | ||
| actual = np_redfunc(df, axis=axis, ddof=1) | ||
| elif NUMPY_GE_125 and redfunc == "product": | ||
| elif NUMPY_GE_125 and redfunc == "product" and not NUMPY_GE_200: |
There was a problem hiding this comment.
Could also be changed to skip in the parameterized section
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 25m 1s ⏱️ - 3m 2s Results for commit 8603869. ± Comparison against base commit 814ed3b. |
phofl
approved these changes
May 2, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves #11066 further along but does not close it. Locally, the rest of dask/dataframe passes with NumPy2
cc @phofl