-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock documentation build #10807
Unblock documentation build #10807
Conversation
5ffb71e
to
7c14d41
Compare
Tried with mamba: https://readthedocs.org/projects/dask/builds/23132383/ environment.yml
|
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 27m 54s ⏱️ - 14m 37s For more details on these failures, see this check. Results for commit 57569d8. ± Comparison against base commit ca42dcf. ♻️ This comment has been updated with latest results. |
-1 from me about pip-compile. Past experience with exact pins has been unexpectedly painful for me. |
Sure thing, no problem. Out of curiosity, do you remember what your pains have been? W/o pinning application requirements I find myself doing this little number every now and again. My experience with fully pinned requirements outside of libs have been rather pleasant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger! One minor comment about a comment
My experience, specifically with conda, is that builds can be deleted by the author or by maintenance bots and it's happened to me many times that an exact-pin conda environment (output of I don't have first-hand experience with pip. |
pre-commit run --all-files
Just restricting the newish slew of releases from sphinxcontrib which made the
sphinx>=5
start failing. Feel free to merge this now, while I still poke at who's causing the <=4.5.0 restriction.Caused by
dask-sphinx-theme
pinned tosphinx-book-theme==0.2.0
which requires sphinx<5.xref dask/dask-sphinx-theme#68