-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure map_partitions
returns Series
object if function returns scalar
#10739
Open
fjetter
wants to merge
4
commits into
dask:main
Choose a base branch
from
fjetter:ensure_map_partitions_returns_series
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
is_datetime64_any_dtype, | ||
is_extension_array_dtype, | ||
is_numeric_dtype, | ||
is_scalar, | ||
is_timedelta64_dtype, | ||
) | ||
from tlz import first, merge, partition_all, remove, unique | ||
|
@@ -3530,7 +3531,12 @@ def _cum_agg( | |
# cumulate each partitions | ||
name1 = f"{self._token_prefix}{op_name}-map" | ||
cumpart = map_partitions( | ||
chunk, self, token=name1, meta=self, **chunk_kwargs | ||
chunk, | ||
self, | ||
token=name1, | ||
meta=self, | ||
**chunk_kwargs, | ||
enforce_metadata=False, | ||
) | ||
|
||
name2 = f"{self._token_prefix}{op_name}-take-last" | ||
|
@@ -3540,6 +3546,7 @@ def _cum_agg( | |
skipna, | ||
meta=meta_series_constructor(self)([], dtype="float"), | ||
token=name2, | ||
enforce_metadata=False, | ||
) | ||
|
||
suffix = tokenize(self) | ||
|
@@ -4161,7 +4168,7 @@ def rename(self, index=None, inplace=no_default, sorted_index=False): | |
-------- | ||
pandas.Series.rename | ||
""" | ||
from pandas.api.types import is_dict_like, is_list_like, is_scalar | ||
from pandas.api.types import is_dict_like, is_list_like | ||
|
||
import dask.dataframe as dd | ||
|
||
|
@@ -5636,7 +5643,7 @@ def assign(self, **kwargs): | |
isinstance(v, Scalar) | ||
or is_series_like(v) | ||
or callable(v) | ||
or pd.api.types.is_scalar(v) | ||
or is_scalar(v) | ||
or is_index_like(v) | ||
or isinstance(v, Array) | ||
): | ||
|
@@ -7384,6 +7391,10 @@ def apply_and_enforce(*args, **kwargs): | |
func = kwargs.pop("_func") | ||
meta = kwargs.pop("_meta") | ||
df = func(*args, **kwargs) | ||
|
||
if is_scalar(df) and is_series_like(meta): | ||
df = type(meta)([df]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ended up removing the explicit |
||
|
||
if is_dataframe_like(df) or is_series_like(df) or is_index_like(df): | ||
if not len(df): | ||
return meta | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using
map_partitions
internally we sometimes rely on the data not being cast to a Series. The cumulative aggregation logic becomes quite cumbersome otherwise. I hope this is not introducing any other weird artefacts 🤞