Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run upstream CI build on Python 3.12 #10663

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/additional.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
miniforge-version: latest
use-mamba: true
channel-priority: strict
python-version: "3.11"
environment-file: continuous_integration/environment-3.11.yaml
python-version: "3.12"
environment-file: continuous_integration/environment-3.12.yaml
activate-environment: test-environment
auto-activate-base: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ jobs:
miniforge-version: latest
use-mamba: true
channel-priority: strict
python-version: "3.11"
environment-file: continuous_integration/environment-3.11.yaml
python-version: "3.12"
environment-file: continuous_integration/environment-3.12.yaml
activate-environment: test-environment
auto-activate-base: false

Expand Down
3 changes: 1 addition & 2 deletions continuous_integration/environment-3.12.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ dependencies:
- sparse
- cachey
- python-graphviz
# Not available on macOS for Python 3.12 yet
# - python-cityhash
- python-cityhash
- python-xxhash
- mmh3
- jinja2
Expand Down
3 changes: 2 additions & 1 deletion continuous_integration/scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ if [[ ${UPSTREAM_DEV} ]]; then
# FIXME https://github.com/mamba-org/mamba/issues/412
# mamba uninstall --force ...
conda uninstall --force fastparquet
# Include `git+https://github.com/pydata/sparse` once there is Python 3.12 compat
# (xref https://github.com/pydata/sparse/issues/610)
python -m pip install \
--upgrade \
locket \
git+https://github.com/pydata/sparse \
git+https://github.com/dask/s3fs \
git+https://github.com/intake/filesystem_spec \
git+https://github.com/dask/partd \
Expand Down
2 changes: 1 addition & 1 deletion dask/tests/test_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_development_guidelines_matches_ci():
development_doc_file = root_dir / "docs" / "source" / "develop.rst"
additional_ci_file = root_dir / ".github" / "workflows" / "additional.yml"
upstream_ci_file = root_dir / ".github" / "workflows" / "upstream.yml"
latest_env = "environment-3.11.yaml"
latest_env = "environment-3.12.yaml"

for filename in [development_doc_file, additional_ci_file, upstream_ci_file]:
with open(filename, encoding="utf8") as f:
Expand Down
2 changes: 1 addition & 1 deletion docs/source/develop.rst
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ pip or conda_

``conda``::

conda env create -n dask-dev -f continuous_integration/environment-3.11.yaml
conda env create -n dask-dev -f continuous_integration/environment-3.12.yaml
conda activate dask-dev
python -m pip install --no-deps -e .

Expand Down