New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run upstream
build with Python 3.10
#9655
Conversation
_full.__doc__ = _full.__doc__.replace( | ||
">>> np.full_like(y, [0, 0, 255])", | ||
">>> np.full_like(y, [0, 0, 255]) # doctest: +NORMALIZE_WHITESPACE", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, this is because numpy
docstests ignore whitespace (xref numpy/numpy#17472)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, the changes here get out upstream
CI build running again. Assuming there are no related failures, I'll plan to merge this PR after CI finishes as I suspect the changes here aren't particularly controversial and it'd be good to get our upstream
build running ASAP. Happy to address any comments folks have in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
@@ -68,5 +68,8 @@ dependencies: | |||
- mmh3 | |||
- jinja2 | |||
- pip | |||
# The nightly pyarrow / arrow-cpp packages currently don't install with latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still a problem, I assume you checked but asking just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing @ncclementi. Yeah, this is still an issue. I initially forgot to transfer this change over to the 3.10 environment file and saw the solve issue from #9465 show up
Possibly closes #9654