Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run upstream build with Python 3.10 #9655

Merged
merged 6 commits into from Nov 14, 2022
Merged

Conversation

jrbourbeau
Copy link
Member

Possibly closes #9654

@github-actions github-actions bot added the documentation Improve or add to documentation label Nov 14, 2022
@github-actions github-actions bot added the array label Nov 14, 2022
Comment on lines +205 to +208
_full.__doc__ = _full.__doc__.replace(
">>> np.full_like(y, [0, 0, 255])",
">>> np.full_like(y, [0, 0, 255]) # doctest: +NORMALIZE_WHITESPACE",
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is because numpy docstests ignore whitespace (xref numpy/numpy#17472)

Copy link
Member Author

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, the changes here get out upstream CI build running again. Assuming there are no related failures, I'll plan to merge this PR after CI finishes as I suspect the changes here aren't particularly controversial and it'd be good to get our upstream build running ASAP. Happy to address any comments folks have in a follow-up PR

Copy link
Member

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@@ -68,5 +68,8 @@ dependencies:
- mmh3
- jinja2
- pip
# The nightly pyarrow / arrow-cpp packages currently don't install with latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still a problem, I assume you checked but asking just in case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @ncclementi. Yeah, this is still an issue. I initially forgot to transfer this change over to the 3.10 environment file and saw the solve issue from #9465 show up

@jrbourbeau jrbourbeau mentioned this pull request Nov 14, 2022
@jrbourbeau jrbourbeau merged commit 98b878d into dask:main Nov 14, 2022
@jrbourbeau jrbourbeau deleted the upstream-py310 branch November 14, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array documentation Improve or add to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream CI build failing due to pyarrow install
2 participants