Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

da.full docstring has np.full_like content #9656

Open
jrbourbeau opened this issue Nov 14, 2022 · 1 comment
Open

da.full docstring has np.full_like content #9656

jrbourbeau opened this issue Nov 14, 2022 · 1 comment
Labels
bug Something is broken documentation Improve or add to documentation needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer.

Comments

@jrbourbeau
Copy link
Member

jrbourbeau commented Nov 14, 2022 •
edited

I noticed in our API docs, it appears da.full is wrapping np.full_likes docstring, when it should be wrapping np.full. Maybe this was introduced with the recent backend dispatching changes? cc @rjzamora

This might (haven't confirmed yet) be causing the doctest failures we're seeing in #9655.

EDIT: Here's a relevant screenshot

Screen Shot 2022-11-14 at 1 34 46 PM
@jrbourbeau jrbourbeau added documentation Improve or add to documentation bug Something is broken labels Nov 14, 2022
@rjzamora
Copy link
Member

It looks like full was wrapping np.full_like before the dispatching changes went in. Perhaps that should have been _full = w(broadcast_trick(np.full))?

@github-actions github-actions bot added the needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer. label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken documentation Improve or add to documentation needs attention It's been a while since this was pushed on. Needs attention from the owner or a maintainer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrbourbeau @rjzamora