Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream CI build #882

Merged
merged 6 commits into from Nov 18, 2021
Merged

Add upstream CI build #882

merged 6 commits into from Nov 18, 2021

Conversation

jrbourbeau
Copy link
Member

There was a recent issue where a dask release broke dask-ml (xref #870). This issue has since been fixed, but it would be nice to catch these types of breakages before an upstream dependency releases. To help increase visibility, this PR proposes we add a new upstream CI build, which is very similar to the one used in Dask's CI, to run the dask-ml test suite against the latest development version of a few key upstream dependencies.

In order to not fully block CI for dask-ml when an upstream CI failure occurs, this PR proposes we only run the upstream build on:

  • Pushes to the main branch
  • A nightly cron job (against the current main branch)
  • On pull request commits where the commit message contains the phrase test-upstream (this allows contributors to opt-in to the upstream build for cases when it's useful)

In practice, we've found over in dask/dask that it's relatively easy for a CI job that only runs regularly on main to go unnoticed when a failure pops up. To help increase visibility in these situations, and still not have all CI on all PRs fail, this PR also proposes we add a report job to the upstream CI build which will automatically open an issue in the dask-ml issue tracker if the upstream CI build fails on main.

.github/workflows/upstream.yml Show resolved Hide resolved
ci/install.sh Outdated Show resolved Hide resolved
@jrbourbeau jrbourbeau self-assigned this Nov 16, 2021
@jrbourbeau
Copy link
Member Author

@TomAugspurger thoughts on adding an upstream CI build to dask-ml?

@TomAugspurger
Copy link
Member

Sounds good to me, especially the bit about making it a cron job! Merge whenever you're ready.

@jrbourbeau jrbourbeau merged commit cf24100 into dask:main Nov 18, 2021
@jrbourbeau jrbourbeau deleted the upstream branch November 18, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants