Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST Fixes random seed for flaky test_keras #800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TST Fixes random seed for flaky test_keras #800

wants to merge 2 commits into from

Conversation

thomasjpfan
Copy link
Contributor

Follow up to #794

I suspect the failing test on main is due to sampling of the parameter space that may lead to scores that are constant.

CC @stsievert

stsievert
stsievert reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@stsievert stsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, random_state is producing the errors. I'm not seeing why else the test would be non-deterministic.

tests/model_selection/test_keras.py Outdated Show resolved Hide resolved
@thomasjpfan @stsievert
Update tests/model_selection/test_keras.py
ce07328 
Co-authored-by: Scott Sievert <stsievert@users.noreply.github.com>
@stsievert
Copy link
Member

Hm.... looks like the error has to do with timeout on windows. I'm not seeing how that's induced by this PR.

@thomasjpfan
Copy link
Contributor Author

thomasjpfan commented Mar 1, 2021 •
edited

The same windows test is also failing on main: https://dev.azure.com/dask-dev/dask/_build/results?buildId=1961&view=logs&jobId=2eab4704-62a3-55d0-a524-46b534a6e811&j=2eab4704-62a3-55d0-a524-46b534a6e811&t=24a2918a-3d47-54f3-09aa-2db1b58035d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsievert stsievert stsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasjpfan @stsievert