Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for the sphinx version problem in the readthedocs build environment #354

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

m-albert
Copy link
Collaborator

This PR addresses #351 by implementing dask/dask-sphinx-theme#68 (comment).

Further discussions here readthedocs/readthedocs.org#11140.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marvin! 🙏

Only suggestion would to put the comment before all of the pip requirements

continuous_integration/environment-doc.yml Outdated Show resolved Hide resolved
@jakirkham jakirkham mentioned this pull request Feb 24, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham
Copy link
Member

jakirkham commented Feb 26, 2024

One of the gpuCI jobs crashed, restarted it

Edit: Looks like that fixed it

@jakirkham jakirkham merged commit a6c0b93 into dask:main Feb 26, 2024
15 checks passed
@jakirkham
Copy link
Member

Thanks Marvin! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants