Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, it turns out that dask/dask#10671 is not necessarily a problem. The problem why the reduction test originally failed is because the
Scalar
object had a python bool as it's meta instead of a numpy bool. Dask's assert logic has a special path for numpy dtypes that implements a more forgiving equality check I ran into here.I suspect this is something we'll run into many times when comparing with the dask/dask test suite. This feels like something
make_meta
should deal with already properly. I'll poke around dask/dask if we can fix it at the source.