Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta for reduction scalars #477

Closed
wants to merge 1 commit into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Dec 6, 2023

So, it turns out that dask/dask#10671 is not necessarily a problem. The problem why the reduction test originally failed is because the Scalar object had a python bool as it's meta instead of a numpy bool. Dask's assert logic has a special path for numpy dtypes that implements a more forgiving equality check I ran into here.

I suspect this is something we'll run into many times when comparing with the dask/dask test suite. This feels like something make_meta should deal with already properly. I'll poke around dask/dask if we can fix it at the source.

@fjetter
Copy link
Member Author

fjetter commented Dec 6, 2023

hmm this fix is not working well it seems. I think dask/dask#10677 will be better

@fjetter fjetter closed this Dec 6, 2023
@fjetter fjetter deleted the meta_for_reduction_scalar branch December 6, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant