New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xfail
consistently for known failing tests
#867
Changes from all commits
bfa990d
4c3c9ad
3c6f404
32997cc
cebc475
3395a02
74bedf7
d57e949
9fb367b
fd50a46
2f5fb4e
2177378
f0bf4d8
3cdaa46
2cfdbf7
349b7fc
86a72a5
1f74895
75db170
479e9e0
890a417
90a4310
658354f
5f5a960
49d0f72
d9ecc75
4ff69ae
0035383
37dc53b
07dfb41
cc10500
af7830d
8783b84
6fd50f2
ee0e689
96434b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -332,15 +332,15 @@ def gpu_client(gpu_cluster): | |
# client for all computations. otherwise, only connect to a client | ||
# when specified. | ||
@pytest.fixture( | ||
scope="function" if SCHEDULER_ADDR is None else "session", | ||
scope="function", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When we use a session-wide client for external cluster testing, it ends up getting blown away with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also wonder if Either way I didn't see a noticeable change in overall test runtimes with this change so it might be okay to improve later. |
||
autouse=False if SCHEDULER_ADDR is None else True, | ||
) | ||
def client(): | ||
with Client(address=SCHEDULER_ADDR) as client: | ||
yield client | ||
|
||
|
||
skip_if_external_scheduler = pytest.mark.skipif( | ||
os.getenv("DASK_SQL_TEST_SCHEDULER", None) is not None, | ||
xfail_if_external_scheduler = pytest.mark.xfail( | ||
condition=os.getenv("DASK_SQL_TEST_SCHEDULER", None) is not None, | ||
reason="Can not run with external cluster", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastapi>=0.87.0
pulls instarlette>=0.21.0
, which switched to usinghttpx
instead ofrequests
for itsTestClient
API (encode/starlette#1376); it's not immediately obvious to me how to support both versions of the API, so this pins us to the olderstarlette
packages for now.