New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xfail
consistently for known failing tests
#867
Merged
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
bfa990d
Uncomment tests in test_compatibility.py
charlesbluca 4c3c9ad
Uncomments tests in test_explain.py
charlesbluca 3c6f404
xfail instead of skipping for failing independent cluster tests
charlesbluca 32997cc
Switch skips to xfails in test_groupby.py
charlesbluca cebc475
Uncomments tests in test_over.py
charlesbluca 3395a02
Switch skips to xfails in test_postgres.py
charlesbluca 74bedf7
Uncomments tests in test_rex.py
charlesbluca d57e949
Switch skips to xfails in test_schema.py
charlesbluca 9fb367b
Switch skips to xfails in test_jdbc.py
charlesbluca fd50a46
Switch skips to xfails in test_sample.py
charlesbluca 2f5fb4e
Switch skips to xfails in test_server.py
charlesbluca 2177378
Uncomments tests in test_context.py
charlesbluca f0bf4d8
Un-xfail passing tests
charlesbluca 3cdaa46
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca 2cfdbf7
Add xfails to some broken tests
charlesbluca 349b7fc
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca 86a72a5
xfail alter table/schema tests
charlesbluca 1f74895
Un-xfail test_regr_aggregation on GPU
charlesbluca 75db170
Merge branch 'main' into uncommment-tests
charlesbluca 479e9e0
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca 890a417
Fix external scheduler xfail
charlesbluca 90a4310
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca 658354f
Merge branch 'main' into uncommment-tests
charlesbluca 5f5a960
Merge branch 'main' into uncommment-tests
ayushdg 49d0f72
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca d9ecc75
Replace skip_if_external_scheduler in ML wrapper tests
charlesbluca 4ff69ae
unxfail test_date_functions
charlesbluca 0035383
Set max constraint for fastapi
charlesbluca 37dc53b
Skip test_iterative_and_prediction on cluster
charlesbluca 07dfb41
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca cc10500
Fix style errors
charlesbluca af7830d
Remove uses of skip_if_external_scheduler
charlesbluca 8783b84
Resolve remaining cluster tests
charlesbluca 6fd50f2
Merge branch 'main' into uncommment-tests
charlesbluca ee0e689
Merge remote-tracking branch 'origin/main' into uncommment-tests
charlesbluca 96434b0
un-xfail fugue tests
charlesbluca File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fastapi>=0.87.0
pulls instarlette>=0.21.0
, which switched to usinghttpx
instead ofrequests
for itsTestClient
API (encode/starlette#1376); it's not immediately obvious to me how to support both versions of the API, so this pins us to the olderstarlette
packages for now.