Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor assignment logic to aliasing same column multiple times on GPU #1134

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charlesbluca
Copy link
Collaborator

Refactors our DataContainer.assign logic to avoid creating a dataframe with multiple columns on GPU, which silently fails and causes errors later down the road.

Closes #1133

@charlesbluca charlesbluca marked this pull request as draft May 4, 2023 19:46
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Merging #1134 (aca4a44) into main (108e024) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   81.42%   81.25%   -0.17%     
==========================================
  Files          78       78              
  Lines        4392     4390       -2     
  Branches      796      796              
==========================================
- Hits         3576     3567       -9     
- Misses        639      640       +1     
- Partials      177      183       +6     
Impacted Files Coverage Δ
dask_sql/datacontainer.py 95.45% <100.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to select same column under multiple aliases on GPU
2 participants